Page MenuHomePhabricator

Fix more PHP 8.1 "strlen(null)" callsites
Needs ReviewPublic

Authored by vm on Jun 7 2022, 7:48 PM.
Tags
None
Referenced Files
F13281574: D21853.diff
Sun, Jun 2, 10:56 AM
F13278797: D21853.id52085.diff
Sat, Jun 1, 5:03 AM
F13278796: D21853.id.diff
Sat, Jun 1, 5:03 AM
F13274910: D21853.diff
Fri, May 31, 4:12 AM
F13270486: D21853.id52085.diff
Wed, May 29, 9:47 AM
F13270485: D21853.id.diff
Wed, May 29, 9:47 AM
F13244771: D21853.diff
Thu, May 23, 5:18 AM
F13244768: D21853.diff
Thu, May 23, 5:18 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T13588: PHP 8 Compatibility
Summary

Noticed some failures with a custom UnitEngine after upgrading to
PHP 8.1
Was able to work around it by setting empty strings but this should fix the
underlying problem.

Test Plan

arc unit no longer fails with no namespace set on UnitTestResult

Diff Detail

Repository
rARC Arcanist
Branch
fix_8.1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25761
Build 35589: arc lint + arc unit