Page MenuHomePhabricator
Create Task
Maniphest T9542

Herald actions should include ability to "mark with named flag" or similar
Closed, InvalidPublic
Actions

Description

When creating a Herald rule, in particular a global rule, it would be nice if one of the possible actions was to add named "flags"/"reminders"/"suggestions". Currently the options are basically to add a (blocking) reviewer, notify or add a colored flag, but colored flags are not as immediately informative as (and need more convention/context than) a brief text snippet. This could be used for things like:

  • "if no tests are part of diff, add 'tests needed' flag"
  • "if code X is touched, add 'update version' flag"
  • "If summary contains 'blah', add 'blah' flag"

Ideally whenever each of these named flags/reminders are created they could be associated with a URL documenting why they were created in the first place, and what actions to take.

Event Timeline

eescardo created this task.Oct 9 2015, 5:09 PM
eescardo updated the task description. (Show Details)
eescardo added a project: Restricted Project.
eescardo added subscribers: jhurwitz, angie, eescardo.
epriestley added a subscriber: epriestley.Oct 9 2015, 5:31 PM

Flags are personal bookmarks (other users can not see your flags), so I think they aren't compatible with your goal. You want everyone looking at a revision to be able to see the note, right?

Can you do this with projects instead? Use a project icon like "Goal" or "Tag", name the project "Needs Tests", give it some conventional color if you want, then use "Add projects..." as the Herald action?

epriestley added a comment.Oct 9 2015, 5:32 PM

(And the project description can be used to document what the project means, how to respond to it, etc. And you can search for revisions with those projects, etc.)

eescardo added a comment.Oct 9 2015, 6:02 PM

@epriestley, thanks for the suggestion. I'll try that workflow and report back if it doesn't work for me. Thanks!

eescardo added a comment.Oct 9 2015, 6:02 PM

And yes, I did mean for this to be a global action, so the flags won't work for it as you said. I was just anchoring on "flags" as "some UI that looks almost like what I want but not quite"

angie closed this task as Invalid.Oct 9 2015, 7:42 PM
angie claimed this task.
angie moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Phabricator · Built by Phacility