Page MenuHomePhabricator

Error: Parameter passed to "setChar()" must be an integer. when using ArcanistPyLintLinter.
Closed, ResolvedPublic

Description

We're started using ArcanistPyLintLinter and started running in the following error:

Exception
Some linters failed:
    - Exception: Parameter passed to "setChar()" must be an integer.
(Run with `--trace` for a full exception trace.)

After investigating I determined that if your python file looks like this:

"""Docstring"""

"""
Useless string """

arc lint will die. This happens because pylint returns -1 for the column value when it hits that Useless String

'pylint' '--reports=no' '--msg-template="{line}|{column}|{msg_id}|{symbol}|{msg}"' '/Users/david/src/client/badfile.py'
No config file found, using default configuration
************* Module badfile
4|-1|W0105|pointless-string-statement|String statement has no effect

I fixed it locally by copying the ArcanistPyLintLinter to our repo and modifying it by casting the value to an int before passing it to getChar but I figured you might want to know that it's broken.

Event Timeline

deuresti updated the task description. (Show Details)
deuresti added a subscriber: deuresti.
jhurwitz added a project: Restricted Project.Aug 25 2015, 2:50 AM
jhurwitz added a subscriber: jhurwitz.

Do you have rARCe5946ed?

(If you aren't sure, show me the hash of git show in arcanist/ and I can hunt it down.)

At a minimum, it looks like you don't have (unrelated) rARC05aaa1a, so you're at least a little bit out of date.

I'd expect that rARCe5946ed fixed this and you just need to update, but let me know if this still reproduces with that change.

Oh, sorry -- after looking at it a little more, you certainly have that patch. I'll take a look at this, thanks.

I'm running the latest arc manually. :)

This should be fixed at HEAD. Thanks for the report! Let us know if you run into anything else.

angie moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Aug 25 2015, 10:27 PM

@deuresti can you confirm this has been resolved?

angie moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Oct 14 2015, 7:17 PM