Page MenuHomePhabricator

"Attending" in Calendar list view shows all users, not just attending users
Closed, ResolvedPublic

Description

To reproduce:

  • Create an event.
  • Invite several users: a, b, c.
  • Remove some of them: b, c.
  • View the event in a list view ("Upcoming Events").

Expected:

  • See "Attending: a" (or nothing, if A has not accepted).

Actual:

  • See "Attending: a, b, c".

Presumably:

  • This is probably showing removed/declined invites, but should not.
  • This should either only show accepted invites, or use language like "Invited:" instead of "Attending:" if it shows invited and attending users.

Original Report

The query shows:

(screenshot of a lot of users listed in list view)

But the state of the event is:

(screenshot of event detail with only some of those users actually attending)

Note that the attendees were removed.

(Also I'd expect the query to only show people who have accepted the invite, not all of the people on the invite list)

Event Timeline

hach-que raised the priority of this task from to Needs Triage.
hach-que updated the task description. (Show Details)
hach-que added a project: Calendar.
hach-que changed the visibility from "Public (No Login Required)" to "Custom Policy".
hach-que added subscribers: hach-que, epriestley, lpriestley.
epriestley changed the visibility from "Custom Policy" to "Public (No Login Required)".Jul 20 2015, 11:44 AM

@epriestley that custom policy was intentionally set as the screenshots contain the names of people who may not want them on the internet (plus other event details and whatnot)

hach-que changed the visibility from "Public (No Login Required)" to "Custom Policy".Jul 20 2015, 12:11 PM
epriestley changed the visibility from "Custom Policy" to "Public (No Login Required)".

I destroyed F641702 and F641705.

epriestley renamed this task from Calendar event queries show wrong attendee list to "Attending" in Calendar list view shows all users, not just attending users.Apr 6 2016, 3:02 PM
epriestley assigned this task to lpriestley.
epriestley updated the task description. (Show Details)
epriestley moved this task from Backlog to Unprototype (v1) on the Calendar board.

A few possible directions:

  1. Leave as "Attending: ...". Then we would have to only include participants that actually accepted an invite. I assume that not all teams are very diligent about sending an RSVP to events, so there would be many events where no one or few people have accepted or declined. I also think that this does not really fit into the "Upcoming events" saved query, because as an invitee, I'd like to see all upcoming events I'm invited to, not just the ones I've accepted (which begs the question, how did I find the invite in the first place if the event didn't show up in my main saved query).
  2. Switch to something like "Invited / confirmed: ...". I'd want to see events that I've been invited to, and ones that I've already said I'd attend. Because "invited" and "accepted" are two different statuses, I'd assume here we'd show both. If we do this, we'd have to probably figure out what to call a status that is invited and/or attending. Basically this would mean anyone that hasn't declined or been uninvited.
  3. Third option is to completely decouple the idea that invited and attending are similar statuses. This would mean making 2 saved queries: "Invited" and "Attending" which would take the place of the previous "Upcoming Events" saved query.

Option 2 is probably the closest to a compromise between 1 and 3, but I can't think of any reason why 3 would be too much work. Maybe it would?

I think it's OK for the UI to show different stuff from the actual query fields -- it's OK to query by "Invited" but see "Attending" in the list. It's just confusing right now because it says "Attending: ..." but includes not-RSVP'd users.

"Upcoming Events" is also currently all events, not just your events, I think?

So I'd be inclined to do (1) first, but only change the list UI without changing any of the search/query stuff.

I think also allowing you to query for events that you (or other users) are attending is reasonable, but we don't need to pursue that right now since no one has actually asked for it, unless you want to.

A possible route for that would be with typeahead functions, so we'd still have one "Invited" field but you could type attending(epriestley) or declined(epriestley) or similar into it. The advantage of this approach is that we don't need to have 4 different fields; the disadvantage is that it's significantly more complex to implement.