It takes too many clicks to accept an audit. Google’s critique had an always-visible bar at the top of every page that had a red “reply” button to let you type a message / choose an action, and a blue “quick accept” button, that in one click would approve the change, reply with “lgtm”, and take you back to the homepage. This was *amazing* from a productivity perspective. When dealing with 100+ audits it’s really frustrating to have to scroll to the bottom, click the dropdown, click the accept option, click the reply button, wait for the page to load, go back to the homepage, click the audits tab, find where i left off, open the next audit.
Description
Description
Related Objects
Related Objects
Event Timeline
Comment Actions
Is there any actual review happening in this workflow or is it just about getting the 100+ audits to an accepted state as quickly as possible?
The latter strongly suggests having some sort of mass actions ability off search results. Curious on the latter as well if there are any ideas about not generating audits that basically just need to be closed?
Comment Actions
Thanks for the response. There is absolutely review going on. Until my team launches our product we will depend pretty heavily on post-commit reviews, so it's not uncommon for me to have 50-150 audits in one week to review. A lot of those will be really small commits, only a couple of lines, so I can accept them pretty quickly. Probably 90% of the audits will be accepted without any comments right now, so I guess this is a request to maybe try to optimize for that?
One small corner case is if someone has a branch with a few commits, pushes the branch, rebases the branch, and then pushes again. Then there will be "two copies" of every audit, so a mass action thing might be nice, but that is fairly rare.
Comment Actions
Sorry but I'm not entirely sure that these are actually the same issue:
In t5815, btrahan specifically said that he was not going to implement a "quick accept" button. Instead was planning to implement a "go to next" mode.
Personally I won't really find that helpful, I just cmd-click and open 100 audits . The main reason why is the page load time in phab is too slow to wait for phab to submit the post request and redirect me to a new page and wait for that page and all the files to fully load.
I understand if you don't want to clutter your ui or w/e with another button. Could you at least add a js api or a keyboard shortcut for quick-accepting an audit? That would be much appreciated and might be a super quick solution?
Comment Actions
We generally prefer to group problems together. Specifically, this is exactly the same problem as T5815. We want to solve many problems with a single solution, when possible. So whether you're working through 100 tasks to triage, or 100 audits to review, or 100 people to validate, we'll approach it from the same perspective. T5815 should include investigating allowing customization of the workflow itself and not just the stack. If you have additional thoughts, they should be added there.