Page MenuHomePhabricator
Create Task
Maniphest T5190

Transactions are shown as being "via Legacy"
Closed, DuplicatePublic
Actions

Description

I've noticed that new transactions can sometimes be shown as being "via Legacy". Some examples can be seen on T5141. I'm not sure what causes this but it doesn't seem like the intended behavior.

Event Timeline

joshuaspence created this task.May 26 2014, 10:17 PM
joshuaspence assigned this task to epriestley.
joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence updated the task description. (Show Details)
joshuaspence added a project: Transactions.
joshuaspence added a subscriber: joshuaspence.
epriestley added subscribers: epriestley, mbishopim3.May 27 2014, 1:23 PM

◀ Merged tasks: T3904.

epriestley added a comment.May 27 2014, 1:26 PM

T3904 is a duplicate but this task is a little more descriptive about the remaining issues.

These "Legacy" transactions are being generated by Maniphest's edge event listener. I think edge event listeners were a technical blunder on my part, and we should move away from them. We could fix this by changing the content source to "Web" (which is probably true in almost all cases) but a better solution would be to move this logic out of event listeners and into TransactionEditors.

epriestley added a comment.Jul 12 2014, 2:26 PM

This should be resolved by edge event removal associated with T5245.

epriestley closed this task as a duplicate.Jul 12 2014, 2:27 PM

✘ Merged into T5245.

Phabricator · Built by Phacility