Page MenuHomePhabricator
Create Task
Maniphest T12324

Dashboards that contain a restricted panel have all query panels stuck in 'Loading...'
Closed, DuplicatePublic
Actions

Description

This seems to be caused by the removal of the Documents query type from the query type selection in Panels. I'm not sure whether this is a bug or intentional, but I couldn't find a reference to it in the changelog.

  1. Add a document search query panel to a dashboard while still on week 7 stable (option has disappeared in week 8 stable).
  2. Upgrade to current stable branch (week 8).
  3. All query panels are now stuck with a 'Loading...' message instead of their actual content.
  4. Remove document search panel. Other query panels start working again.

phabricator c8f5fb120573f6b1a001ba78f4f8f5bc1c453e43 (Sat, Feb 25) (branched from c15501fc9b06f46a699bcded6d2e14c5c48af2db on origin)
arcanist 822bc53ca306e06314560d8a76f68771d732e8e0 (Sat, Feb 25) (branched from 3b6b523c2b236e3724a1e115f126cb6fd05fa128 on origin)
phutil e3381770af0fa8a01ca1e1078b041c00c7baab5a (Sat, Feb 25) (branched from 0625e4d28b16cba8b0154e49dc31845559b4e704 on origin)

Revisions and Commits

rP Phabricator
D17588rP7ab4e7dbced9 Allow Owner Packages to be in a Dashboard Panel
D17428rP54059b0a9d87 Add fulltext search results panel back for dashboards

Related Objects

Event Timeline

ivo created this task.Feb 27 2017, 5:53 PM
Herald added a subscriber: eadler. · View Herald TranscriptFeb 27 2017, 5:53 PM
chad added a subscriber: chad.Feb 27 2017, 5:58 PM

Can you clarify the steps to reproduce please? I don't know what "Documents" query type is, even reading through the diff that restricted useless panel types.

chad added a comment.Feb 27 2017, 5:59 PM

Specifically, "Wiki Documents" and "Legalpad Documents" both still are available, but "Documentation Atoms" from Diviner are not.

ivo added a comment.Feb 27 2017, 6:05 PM

Reading through the diff you mention (D17341 I think?) I see that the query type was probably called "Fulltext Results". Basically the query panel version of this page: https://secure.phabricator.com/search/query/advanced/

chad added a comment.Feb 27 2017, 6:12 PM

Is that a panel you were using?

chad added a comment.Feb 27 2017, 6:13 PM

I can make a fix so this doesn't fail and grandfather these in if they were in use, but I'd also like to know if people are using these as panels, so I can revert that change if needed.

ivo added a comment.Feb 27 2017, 8:29 PM

Yes, we were using the panel to show all items (tasks, revisions, wiki pages, et cetera) tagged with a certain tag.

chad added a comment.Feb 27 2017, 8:37 PM

Instead of Feed?

chad added a revision: D17428: Add fulltext search results panel back for dashboards.Feb 27 2017, 8:41 PM
chad added a commit: rP54059b0a9d87: Add fulltext search results panel back for dashboards.Feb 27 2017, 8:45 PM
ivo added a comment.Feb 27 2017, 9:02 PM

Feed shows stuff that is happening to items with a certain tag. We want to list the items themselves, not what is happening to them.

We use this so users can tag items any they need help with. These will show up on the dashboard of other users, who can take a look and help out if they've got some time available.

chad added a comment.Feb 27 2017, 9:12 PM

I added the panel back as an option. I'll leave this open until we see if anyone else hits a similar case.

chad renamed this task from Dashboards that contain a PhabricatorSearchApplicationSearchEngine panel have all query panels stuck in 'Loading...' to Dashboards that contain a restricted panels have all query panels stuck in 'Loading...'.Feb 27 2017, 9:34 PM
chad renamed this task from Dashboards that contain a restricted panels have all query panels stuck in 'Loading...' to Dashboards that contain a restricted panel have all query panels stuck in 'Loading...'.
cspeckmim added a subscriber: cspeckmim.Mar 2 2017, 5:49 AM

I like the idea of a feed/panel that shows recently active objects and not the individual events, but I don't know that I have a specific use case for it now. For how I use feed I think being able to filter out commits would be a nifty plus, as those tend to pollute the feed during arc land activity (and comments in tow). I don't think I feel too strongly about it right now though, as most of my work is driven via email activity and I primarily use Feed as a means of discoverability so I can poke my head in if something sounds interesting~

johnny-bit added a subscriber: johnny-bit.Mar 6 2017, 8:37 PM

Hi! I think I've hit similar issue, but for another type of panel. We've used to use PhrequentSearchEngine panel to show phrequent/query/tracking/ (Currently tracking), which apparently got removed in D17341. Currently tracking on main dashboard was quite interesting indicator for current work aaand could be fun until phrequent gets more useul 😄

chad added a comment.Mar 6 2017, 8:45 PM

I fixed that hours ago.

johnny-bit added a comment.Mar 6 2017, 9:13 PM

You guys fast.

chad added a revision: D17588: Allow Owner Packages to be in a Dashboard Panel.Mar 30 2017, 10:01 PM
chad added a commit: rP7ab4e7dbced9: Allow Owner Packages to be in a Dashboard Panel.Mar 30 2017, 10:13 PM
epriestley added a subscriber: epriestley.Apr 7 2017, 12:47 PM

I'm just going to merge this into T8033 since I our intent there is to prevent this situation entirely.

epriestley closed this task as a duplicate of T8033: Inform editor when panels have more restrictive policy than dashboard.Apr 7 2017, 12:47 PM
Phabricator · Built by Phacility