Page MenuHomePhabricator

Use `git diff a b` for ranges, not `git diff a..b`
ClosedPublic

Authored by epriestley on Jul 11 2014, 4:57 PM.
Tags
None
Referenced Files
F13277832: D9898.id23770.diff
Fri, May 31, 2:12 PM
F13277831: D9898.id23763.diff
Fri, May 31, 2:12 PM
F13277829: D9898.id.diff
Fri, May 31, 2:12 PM
F13270910: D9898.id.diff
Wed, May 29, 2:16 PM
F13262788: D9898.diff
Mon, May 27, 3:45 AM
F13249624: D9898.id23770.diff
Fri, May 24, 9:50 AM
F13244258: D9898.diff
Thu, May 23, 4:39 AM
F13238922: D9898.id.diff
Tue, May 21, 10:40 PM
Subscribers

Details

Summary

These are documented as being identical, but git diff a b works if a is a tree (for example, 4b825d..., the empty tree hash), but git diff a..b does not.

Particularly, with the a..b form, arc diff --base arc:empty does not work. With the a b form, it does.

Test Plan

Ran arc diff --base arc:empty in a repository and got a diff.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Use `git diff a b` for ranges, not `git diff a..b`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: talshiri, btrahan.
talshiri edited edge metadata.
This revision is now accepted and ready to land.Jul 11 2014, 5:43 PM
epriestley updated this revision to Diff 23770.

Closed by commit rARCf9f2092246d2 (authored by @epriestley).