Page MenuHomePhabricator

Make column reordering after edits on workboards more general
ClosedPublic

Authored by epriestley on Jul 5 2014, 7:24 PM.
Tags
None
Referenced Files
F13289979: D9832.diff
Tue, Jun 4, 2:48 PM
F13274375: D9832.diff
Fri, May 31, 3:37 AM
F13262462: D9832.diff
Mon, May 27, 2:09 AM
F13260066: D9832.diff
Sun, May 26, 11:27 PM
F13258447: D9832.id23594.diff
Sun, May 26, 9:26 AM
F13256564: D9832.id23707.diff
Sat, May 25, 2:10 PM
F13256563: D9832.id23594.diff
Sat, May 25, 2:10 PM
F13251442: D9832.id23594.diff
Fri, May 24, 11:27 PM
Subscribers

Details

Summary

Ref T5476. Currently, the task edit code assumes it knows what the UI looks like and sends back where on the column an item should be inserted.

This is buggy after adding filters, and relatively complex. Instead, send down the ordering on the whole column and sort it in the UI. This is a bit simpler overall and more general. It makes it easier to further generalize this code for T5476.

Test Plan
  • Edited a task on a board, changing priority. Saw it reorder properly.
  • Edited a task on a board in a field of other tasks at the same top-level priority. Saw it refresh without reordering.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Make column reordering after edits on workboards more general.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 5 2014, 7:39 PM
epriestley updated this revision to Diff 23707.

Closed by commit rPfae23e086049 (authored by @epriestley).