mailgun support messageids. supportsMessageIDHeader accidentally returned false.
ClosedPublic
Actions

Authored by talshiri on Jun 24 2014, 11:18 PM.

Tags

None

Referenced Files

	F13295117: D9715.id.diff
	Wed, Jun 5, 10:44 PM

	F13285784: D9715.diff
	Tue, Jun 4, 2:41 AM

	F13258690: D9715.id23328.diff
	Sun, May 26, 11:56 AM

	F13242411: D9715.diff
	Thu, May 23, 2:44 AM

	F13228727: D9715.id23329.diff
	Mon, May 20, 11:35 AM

	F13220547: D9715.diff
	Sun, May 19, 1:39 AM

	F13202599: D9715.diff
	Tue, May 14, 10:54 PM

	F13185603: D9715.diff
	Sat, May 11, 3:02 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP6f82725a9931: mailgun support messageids. supportsMessageIDHeader accidentally returned false.

Summary

The adapter was mostly copy-paste, and I missed the supportsMessageIDHeader stuff.

Test Plan

Sent a message, checked headers.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

talshiri updated this revision to Diff 23328.Jun 24 2014, 11:18 PM

talshiri retitled this revision from to mailgun support messageids. supportsMessageIDHeader accidentally returned false..

talshiri updated this object.

talshiri edited the test plan for this revision. (Show Details)

talshiri added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 24 2014, 11:18 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1371: Diff 23328.Jun 24 2014, 11:19 PM

epriestley accepted this revision.Jun 24 2014, 11:21 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 24 2014, 11:21 PM

Closed by commit rP6f82725a9931 (authored by @talshiri, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

metamta/

adapter/

PhabricatorMailImplementationMailgunAdapter.php

2 lines

Diff 23329

View Options

src/applications/metamta/adapter/PhabricatorMailImplementationMailgunAdapter.php

mailgun support messageids. supportsMessageIDHeader accidentally returned false.ClosedPublicActions