Differential D9382

Only canonize paths if both sourceControlPath field is present and we're in SVN.
AbandonedPublic
Actions

Authored by talshiri on Jun 5 2014, 3:05 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Summary

This allow arc to send sourceControlPath for git/hg (follow up diff incoming).

Test Plan

tested locally.

Diff Detail

Repository

rP Phabricator

Branch

sourcecontrol_path

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 861
Build 861: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

talshiri updated this revision to Diff 22373.Jun 5 2014, 3:05 AM

talshiri retitled this revision from to Only canonize paths if both sourceControlPath field is present and we're in SVN..

talshiri updated this object.

talshiri edited the test plan for this revision. (Show Details)

talshiri added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 5 2014, 3:05 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B861: Diff 22373.Jun 5 2014, 3:06 AM

I don't understand what this or D9383 are doing. See Contributing Bug Reports / Contributing Feature Requests. "test locally" is not a test plan.

This revision now requires changes to proceed.Nov 23 2015, 3:40 PM

epriestley mentioned this in D9383: return remote for getSourceControlPath.Nov 23 2015, 3:40 PM

Badly designed workaround for an issue we had

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialTransactionEditor.php

5 lines

Diff 22373

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Only canonize paths if both sourceControlPath field is present and we're in SVN.AbandonedPublicActions