Page MenuHomePhabricator
Differential D9282

Add a link to all search results from Query dashboard panels
AbandonedPublic
Actions

Authored by chad on May 24 2014, 6:00 PM.
Tags
None
Referenced Files
F13274484: D9282.diff
Fri, May 31, 3:45 AM
F13266944: D9282.diff
Tue, May 28, 10:18 PM
F13260092: D9282.diff
Sun, May 26, 11:29 PM
F13244044: D9282.diff
Thu, May 23, 4:27 AM
F13221274: D9282.diff
Sun, May 19, 2:24 AM
F13218393: D9282.id22042.diff
Sat, May 18, 12:27 PM
F13218245: D9282.id.diff
Sat, May 18, 11:18 AM
F13218194: D9282.diff
Sat, May 18, 10:48 AM
View All Files
Subscribers
chad
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T5487: "View more" or "View all" in query panels on dashboard
T4986: Implement new Dashboard panel types
Summary

Ref T4986. This is a touch undiscoverable maybe, but seems useful?

Test Plan

Screen_Shot_2014-05-24_at_10.57.16_AM.png (327×853 px, 28 KB)

Diff Detail

Event Timeline

epriestley updated this revision to Diff 22042.May 24 2014, 6:00 PM
epriestley retitled this revision from to Add a link to all search results from Query dashboard panels.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T4986: Implement new Dashboard panel types.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 24 2014, 6:00 PM
epriestley added a subscriber: chad.May 24 2014, 6:01 PM

Maybe @chad too.

Harbormaster completed remote builds in B688: Diff 22042.May 24 2014, 6:02 PM
chad added a comment.May 24 2014, 6:18 PM

I do want to have some icons up there, but need to think about it a little. Like, if it's a pencil are you editing the query or the panel? It's pretty cumbersome to change a query right now, since it'd generate a new key.

Anyways, I would like a "See All" there first, which is what I think you're doing here. We can pick a different icon if this doesn't work.

chad added a comment.May 24 2014, 6:21 PM

(I would also consider linking the header text to this results as well)

btrahan accepted this revision.Jun 3 2014, 9:53 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 3 2014, 9:53 PM
chad added a comment.Dec 17 2014, 9:20 PM

Is this yoink-able?

epriestley added a comment.Dec 17 2014, 9:26 PM

Yeah, go for it.

chad commandeered this revision.Dec 17 2014, 9:37 PM
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptDec 17 2014, 9:37 PM
chad abandoned this revision.Dec 17 2014, 11:30 PM

ok, i've got it running, but it wants to create a new revision. will follow up there.

Revision Contents
Changeset List

Diff 22042

View Options

src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php

Loading...
View Options

src/applications/dashboard/paneltype/PhabricatorDashboardPanelType.php

Loading...
View Options

src/applications/dashboard/paneltype/PhabricatorDashboardPanelTypeQuery.php

Loading...
Phabricator · Built by Phacility