Page MenuHomePhabricator
Differential D8660

Support querying a specific snapshot on phragment.queryfragments
AbandonedPublic
Actions

Authored by hach-que on Apr 1 2014, 1:03 AM.
Tags
None
Referenced Files
F13218040: D8660.diff
Sat, May 18, 9:37 AM
F13209725: D8660.id20538.diff
Fri, May 17, 1:49 AM
F13206757: D8660.diff
Wed, May 15, 5:22 PM
F13194096: D8660.diff
Sun, May 12, 9:18 PM
F13191737: D8660.id24552.diff
Sat, May 11, 11:52 PM
F13183256: D8660.id.diff
Fri, May 10, 7:55 AM
F13178913: D8660.diff
Wed, May 8, 8:47 PM
Unknown Object (File)
Sat, May 4, 6:15 PM
View All Files
Subscribers
epriestley
hach-que
joshuaspence
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5479: Unbeta Phragment
T4884: At some point, review hach-que's diffs
Summary

This allows a snapshot name to be specified when querying for Phragment fragments via Conduit. It also adds the "size" field onto the reported results, which is the size of the file in bytes.

Test Plan

Specified snapshot, saw the data change.

Diff Detail

Repository
rP Phabricator
Branch
arcpatch-D8660
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2126
Build 2130: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que updated this revision to Diff 20538.Apr 1 2014, 1:03 AM
hach-que retitled this revision from to Support querying a specific snapshot on phragment.queryfragments.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers.Apr 1 2014, 1:03 AM
Herald added subscribers: hach-que, Korvin, epriestley.
hach-que updated this revision to Diff 24552.Aug 9 2014, 5:17 AM
hach-que edited edge metadata.

Rebase on master

Harbormaster completed remote builds in B2126: Diff 24552.Aug 9 2014, 5:18 AM
joshuaspence added a subscriber: joshuaspence.Mar 1 2015, 7:18 AM
epriestley requested changes to this revision.May 13 2015, 1:56 PM
epriestley edited edge metadata.

This should wait for T7715 and be rebuilt on top of ApplicationSearch-via-Conduit.

This revision now requires changes to proceed.May 13 2015, 1:56 PM
hach-que mentioned this in D8669: Add phragment.querysnapshots method.Jun 18 2015, 1:28 PM
hach-que abandoned this revision.Jun 18 2015, 2:11 PM

Might as well abandon this as we're no longer using it in production (and is probably still years away on the upstream roadmap).

Revision Contents
Changeset List

PathSize
src/
applications/
phragment/
conduit/
82 lines

Diff 24552

View Options

src/applications/phragment/conduit/PhragmentQueryFragmentsConduitAPIMethod.php

Loading...
Phabricator · Built by Phacility