Page MenuHomePhabricator
Differential D8315

Change "%s" in qsprintf to exclude non-BMP characters
ClosedPublic
Actions

Authored by epriestley on Feb 23 2014, 9:29 PM.
Tags
None
Referenced Files
F13277053: D8315.diff
Fri, May 31, 8:20 AM
F13272814: D8315.diff
Thu, May 30, 10:03 PM
F13266762: D8315.id.diff
Tue, May 28, 7:09 PM
F13257877: D8315.diff
Sun, May 26, 5:13 AM
F13219263: D8315.diff
Sat, May 18, 4:51 PM
F13181066: D8315.id19780.diff
Thu, May 9, 7:59 AM
F13181065: D8315.id19767.diff
Thu, May 9, 7:59 AM
F13181042: D8315.id.diff
Thu, May 9, 7:43 AM
View All Files
Subscribers
aran
arice
chad

Details

Reviewers
arice
btrahan
Maniphest Tasks
T1191: Comments are truncated at first non-base-plane character
Commits
rPHU5a9002ebed4f: Change "%s" in qsprintf to exclude non-BMP characters
Summary

Ref T1191. Make %s in qsprintf reject non-BMP characters. Introduce %B for escaping binary strings.

Basically, this just makes "yes, I want to put binary data in this column" explicit.

Test Plan

See next diff for test coverage in Phabricator.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Revision Contents
Changeset List

Diff 19780

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/aphront/storage/connection/AphrontIsolatedDatabaseConnection.php

Loading...
View Options

src/aphront/storage/connection/mysql/AphrontMySQLDatabaseConnection.php

Loading...
View Options

src/aphront/storage/connection/mysql/AphrontMySQLDatabaseConnectionBase.php

Loading...
View Options

src/aphront/storage/connection/mysql/AphrontMySQLiDatabaseConnection.php

Loading...
View Options

src/aphront/storage/exception/AphrontQueryCharacterSetException.php

Loading...
View Options

src/xsprintf/PhutilQsprintfInterface.php

Loading...
View Options

src/xsprintf/qsprintf.php

Loading...
Phabricator · Built by Phacility