Page MenuHomePhabricator

Remove spinner GIF for loading tokenizers
ClosedPublic

Authored by epriestley on Feb 16 2014, 6:41 PM.
Tags
None
Referenced Files
F13186030: D8249.diff
Sat, May 11, 3:22 AM
F13184816: D8249.diff
Sat, May 11, 12:24 AM
Unknown Object (File)
Tue, May 7, 5:31 AM
Unknown Object (File)
Sun, May 5, 6:07 PM
Unknown Object (File)
Fri, May 3, 3:26 AM
Unknown Object (File)
Mon, Apr 29, 2:42 PM
Unknown Object (File)
Wed, Apr 24, 10:13 PM
Unknown Object (File)
Wed, Apr 24, 2:10 AM
Subscribers

Details

Summary

Ref T4420. I think the border is good enough without this spinny thing, and it needs a lot of code.

Test Plan

Used typeahead.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

We have the luxury of usually be local/intranet installs for most people. Curious how this will do on SaaS, but haven't felt we needed it on secure.

Yeah, I think we could find other display options to make it a little more prominent without needing like 50 lines of code too. We add/remove a class even without this code, and could do various things to make the effect more visible.