Page MenuHomePhabricator

Move the repository policy step into the create workflow
ClosedPublic

Authored by epriestley on Dec 30 2013, 10:21 PM.
Tags
None
Referenced Files
F13286853: D7856.diff
Tue, Jun 4, 7:46 AM
F13280363: D7856.id17788.diff
Sun, Jun 2, 4:15 AM
F13280362: D7856.id17770.diff
Sun, Jun 2, 4:15 AM
F13279772: D7856.id.diff
Sat, Jun 1, 11:08 PM
F13270867: D7856.id17788.diff
Wed, May 29, 1:19 PM
F13269152: D7856.diff
Wed, May 29, 5:52 AM
F13256954: D7856.diff
Sat, May 25, 7:12 PM
F13256549: D7856.diff
Sat, May 25, 1:55 PM
Subscribers

Details

Summary

Fixes T4242. It's currently possible to set nonsense defaults and create repositories with unintended policies, because policy configuration isn't part of creation. Instead:

  • put a policy page into the creation workflow;
  • require the selection of valid policies (i.e., prevent creating a repository you can't view / edit).
Test Plan
  • Created imported and hosted repositories, hit policy selection.
  • Edited policies of existing repositories.
  • Tried to set nonsense policies.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

I don't love making setup more complicated, but this step is pretty straightforward.