Page MenuHomePhabricator
Differential D21845

Move Slowvote vote types to a separate object
ClosedPublic
Actions

Authored by epriestley on May 26 2022, 5:09 PM.
Tags
None
Referenced Files
F13208481: D21845.diff
Thu, May 16, 3:57 PM
F13202274: D21845.diff
Tue, May 14, 10:29 PM
F13198334: D21845.diff
Mon, May 13, 5:49 AM
F13183018: D21845.diff
Fri, May 10, 6:12 AM
Unknown Object (File)
Sat, May 4, 10:31 AM
Unknown Object (File)
Thu, May 2, 11:21 AM
Unknown Object (File)
Wed, May 1, 12:22 PM
Unknown Object (File)
Wed, May 1, 6:06 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default"
Commits
rP9dad49472c04: Move Slowvote vote types to a separate object
Summary

Ref T13682. Extract Slowvote vote types to a separate object, to prepare for turning them into API-friendly string constants.

Test Plan

Created, edited, and voted in Slowvote polls. Grepped for affected constants.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley requested review of this revision.May 26 2022, 5:09 PM
epriestley created this revision.
Harbormaster completed remote builds in B25752: Diff 52064.May 26 2022, 5:09 PM
epriestley updated this revision to Diff 52065.May 26 2022, 5:09 PM
  • Update some file/class names.
Harbormaster completed remote builds in B25753: Diff 52065.May 26 2022, 5:09 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 26 2022, 5:17 PM
Closed by commit rP9dad49472c04: Move Slowvote vote types to a separate object (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP9dad49472c04: Move Slowvote vote types to a separate object.

Revision Contents
Changeset List

Diff 52066

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/slowvote/constants/SlowvotePollVotingMethod.php

Loading...
View Options

src/applications/slowvote/controller/PhabricatorSlowvoteEditController.php

Loading...
View Options

src/applications/slowvote/controller/PhabricatorSlowvoteVoteController.php

Loading...
View Options

src/applications/slowvote/storage/PhabricatorSlowvotePoll.php

Loading...
View Options

src/applications/slowvote/view/SlowvoteEmbedView.php

Loading...
View Options

src/applications/slowvote/xaction/PhabricatorSlowvoteVotingMethodTransaction.php

Loading...
Phabricator · Built by Phacility