Page MenuHomePhabricator

Fix a PHP 8.1 repository marker issue in Mercurial
ClosedPublic

Authored by epriestley on May 17 2022, 11:18 PM.
Tags
None
Referenced Files
F13204551: D21825.diff
Wed, May 15, 12:41 AM
F13198742: D21825.id.diff
Mon, May 13, 9:28 AM
F13198308: D21825.diff
Mon, May 13, 5:41 AM
F13187537: D21825.diff
Sat, May 11, 4:35 AM
F13183373: D21825.diff
Fri, May 10, 8:38 AM
F13183087: D21825.diff
Fri, May 10, 6:54 AM
Unknown Object (File)
Tue, May 7, 7:44 AM
Unknown Object (File)
Mon, May 6, 5:11 PM
Subscribers
None

Details

Summary

Ref T13588. "arc-ls-markers" emits a "branch-state" marker so callers can identify which branch is active in the working copy.

This marker doesn't have an associated commit, so trying to generate a display name fails under stricter PHP 8.1 rules when we try to substr(null, ...).

Don't attempt to generate a display name for markers with no commit hash.

Test Plan
  • Ran arc branches under PHP 8.1 in a Mercurial repository.
  • Before: fatal.
  • After: sensible output.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable