Page MenuHomePhabricator

Fix subtype extension support check
ClosedPublic

Authored by 0 on Aug 20 2021, 6:12 AM.
Tags
None
Referenced Files
F13270130: D21714.diff
Wed, May 29, 9:02 AM
F13229276: D21714.id51734.diff
Mon, May 20, 3:24 PM
Unknown Object (File)
May 6 2024, 6:47 PM
Unknown Object (File)
Apr 20 2024, 5:47 PM
Unknown Object (File)
Apr 6 2024, 5:22 PM
Unknown Object (File)
Apr 6 2024, 11:05 AM
Unknown Object (File)
Mar 31 2024, 3:42 PM
Unknown Object (File)
Mar 28 2024, 6:47 PM
Subscribers

Details

Summary

Fixes T13663. supportsSubtypes tries to create an editable object, but this isn't always valid for PhabricatorCalendarImport. Use instanceof instead.

Test Plan
  • Edited calendar import, tasks (2 different subtypes), and projects (2 different subtypes).
  • Changed task subtypes using Change Subtype action and batch editor.
  • Changed task and project subtypes using Conduit.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable