Page MenuHomePhabricator

Correct an issue where "dashboard.panel.edit" fatals in the API console
ClosedPublic

Authored by epriestley on Jun 1 2021, 6:40 AM.
Tags
None
Referenced Files
F13226356: D21668.id51566.diff
Sun, May 19, 8:15 PM
F13211333: D21668.diff
Fri, May 17, 5:40 AM
F13210978: D21668.id51567.diff
Fri, May 17, 5:22 AM
F13196581: D21668.diff
Sun, May 12, 11:23 PM
Unknown Object (File)
Fri, May 3, 5:24 AM
Unknown Object (File)
Tue, Apr 30, 2:18 PM
Unknown Object (File)
Thu, Apr 25, 12:53 AM
Unknown Object (File)
Tue, Apr 23, 2:05 PM
Subscribers
None

Details

Summary

Ref T13650. Currently, viewing the API console help page for this method fatals because it constructs a generic, untyped panel.

As a step toward improving this, generate a concrete panel type instead. This isn't the best possible fix, see T13650 for discussion.

Test Plan

Viewed "dashboard.panel.edit" API page, now saw a usable page.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable