Page MenuHomePhabricator

Introduce "arc inspect" and some of the new ref/hardpoint classes
ClosedPublic

Authored by epriestley on Apr 10 2020, 11:39 AM.
Tags
None
Referenced Files
F13245100: D21078.id50211.diff
Thu, May 23, 5:43 AM
F13228805: D21078.id50213.diff
Mon, May 20, 12:12 PM
F13220990: D21078.diff
Sun, May 19, 2:10 AM
F13210143: D21078.id.diff
Fri, May 17, 4:15 AM
F13183334: D21078.id50212.diff
Fri, May 10, 8:25 AM
F13177780: D21078.diff
Wed, May 8, 7:57 PM
Unknown Object (File)
Apr 25 2024, 12:40 AM
Unknown Object (File)
Apr 20 2024, 5:11 PM
Subscribers
None

Details

Summary

Ref T11968. Inches toward the new ref/hardpoint code by introducing the modern refs as "RefPro" objects and supporting an "arc inspect <object>" to load objects and hardpoints.

This doesn't impact any existing runtime behavior.

Test Plan

Ran "arc inspect [--all] commit(...)", got hardpoint queries and yield-based data fetching.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 10 2020, 11:40 AM
Harbormaster failed remote builds in B24029: Diff 50211!
  • Don't "return $value" inside generators, since this does not work until PHP7.
This revision was not accepted when it landed; it landed in state Needs Review.Apr 10 2020, 12:01 PM
This revision was automatically updated to reflect the committed changes.