Page MenuHomePhabricator

When publishing a commit, copy "Related Tasks" from the associated revision (if one exists)
ClosedPublic

Authored by epriestley on Jan 30 2020, 6:32 PM.
Tags
None
Referenced Files
F13242761: D20961.id49937.diff
Thu, May 23, 3:05 AM
F13232580: D20961.diff
Tue, May 21, 1:23 AM
F13224617: D20961.id49951.diff
Sun, May 19, 9:37 AM
F13211299: D20961.diff
Fri, May 17, 5:38 AM
F13196555: D20961.diff
Sun, May 12, 11:22 PM
F13191827: D20961.id.diff
Sun, May 12, 1:00 AM
Unknown Object (File)
Fri, May 3, 5:16 AM
Unknown Object (File)
Sat, Apr 27, 12:43 AM
Subscribers
None

Details

Summary

Fixes T13463. Currently, if you use the web UI to set "Related Tasks" for a revision, the resulting commit does not link to the tasks.

If you use "Ref ..." in the message instead, the resulting commit does link to the tasks.

Broadly, this should all be cleaner (see T3577) but we can step toward better behavior by just copying these edges when commits are published.

Test Plan
  • Created a revision.
  • Used the web UI to edit "Related Tasks".
  • Landed the revision.
  • Saw the commit link to the tasks as though I'd used "Ref ..." in the message.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable