Page MenuHomePhabricator

Remove "stronger/weaker" policy color hints from object headers
ClosedPublic

Authored by epriestley on Nov 19 2019, 6:00 AM.
Tags
None
Referenced Files
F13226240: D20918.diff
Sun, May 19, 7:57 PM
F13209612: D20918.id49845.diff
Fri, May 17, 1:08 AM
F13204279: D20918.diff
Wed, May 15, 12:27 AM
F13187157: D20918.diff
Sat, May 11, 4:22 AM
Unknown Object (File)
Tue, May 7, 7:28 AM
Unknown Object (File)
Mon, May 6, 10:26 AM
Unknown Object (File)
Sun, May 5, 8:19 AM
Unknown Object (File)
Fri, May 3, 11:24 PM
Subscribers
None

Details

Summary

Fixes T13461. Some applications provide hints about policy strength in the header, but these hints are inconsistent and somewhat confusing. They don't make much sense for modern objects with Custom Forms, which don't have a single "default" policy.

Remove this feature since it seems to be confusing things more than illuminating them.

Test Plan
  • Viewed various objects, no longer saw colored policy hints.
  • Grepped for all removed symbols.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Nov 19 2019, 6:05 AM
This revision was automatically updated to reflect the committed changes.