Differential D20805

Inline custom policy rules inside policy capability explanation dialogs
ClosedPublic
Actions

Authored by epriestley on Sep 12 2019, 3:39 PM.

Tags

None

Referenced Files

	F13228766: D20805.id49601.diff
	Mon, May 20, 11:53 AM

	F13216945: D20805.id49609.diff
	Sat, May 18, 3:08 AM

	F13207690: D20805.id49609.diff
	Thu, May 16, 2:30 AM

	F13205042: D20805.diff
	Wed, May 15, 1:23 AM

	F13198534: D20805.id.diff
	Mon, May 13, 7:36 AM

	F13198329: D20805.id.diff
	Mon, May 13, 5:48 AM

	F13188336: D20805.diff
	Sat, May 11, 5:11 AM

	Unknown Object (File)
	Tue, May 7, 8:26 AM

View All 92 Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13411: Improve "Custom Policy" behavior in policy dialogs
Commits: rP9a36e6931cf7: Inline custom policy rules inside policy capability explanation dialogs

Summary

Ref T13411. When users click a link to explain a capability (like the policy header on many objects, or the link next to specific capabilities in "Applications", "Diffusion", etc), inline the full ruleset for the custom policy into the dialog if the object has a custom policy.

Test Plan

Screen Shot 2019-09-12 at 8.35.49 AM.png (360×1 px, 42 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 12 2019, 3:39 PM

Harbormaster completed remote builds in B23426: Diff 49601.Sep 12 2019, 3:40 PM

epriestley requested review of this revision.Sep 12 2019, 3:40 PM

epriestley mentioned this in T6802: "Custom policy" for editing/viewing does not link to details.Sep 12 2019, 4:03 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 12 2019, 4:41 PM

Closed by commit rP9a36e6931cf7: Inline custom policy rules inside policy capability explanation dialogs (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP9a36e6931cf7: Inline custom policy rules inside policy capability explanation dialogs.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

src/

__phutil_library_map__.php

applications/

policy/

controller/

PhabricatorPolicyExplainController.php

9 lines

view/

PHUIPolicySectionView.php

12 lines

PhabricatorPolicyRulesView.php

84 lines

transactions/

controller/

PhabricatorApplicationTransactionValueController.php

81 lines

webroot/

rsrc/

css/

phui/

phui-header-view.css

42 lines

phui-policy-section-view.css

62 lines

Diff 49609

resources/celerity/map.php

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/policy/controller/PhabricatorPolicyExplainController.php

Loading...

src/applications/policy/view/PHUIPolicySectionView.php

Loading...

src/applications/policy/view/PhabricatorPolicyRulesView.php

Loading...

src/applications/transactions/controller/PhabricatorApplicationTransactionValueController.php

Loading...

webroot/rsrc/css/phui/phui-header-view.css

Loading...

webroot/rsrc/css/phui/phui-policy-section-view.css

Loading...