Page MenuHomePhabricator

Remove "Editable By" description fields in Passphrase, Phame, and Spaces
ClosedPublic

Authored by epriestley on Sep 12 2019, 2:06 PM.
Tags
None
Referenced Files
F13243719: D20802.diff
Thu, May 23, 4:09 AM
F13242457: D20802.id49598.diff
Thu, May 23, 2:47 AM
F13222136: D20802.diff
Sun, May 19, 3:23 AM
F13204670: D20802.diff
Wed, May 15, 12:49 AM
F13187730: D20802.diff
Sat, May 11, 4:43 AM
Unknown Object (File)
Tue, May 7, 7:54 AM
Unknown Object (File)
Mon, May 6, 11:53 AM
Unknown Object (File)
Mon, May 6, 12:18 AM
Subscribers
None

Details

Summary

Ref T13411. These three applications render an "Editable By: <policy>" field in their descriptions.

The pages that these appear on all have "Edit <thing>" actions which either tell you the policy or allow you to discover the policy, and this field is unusual (the vast majority of objects don't have it). I think it largely got copy/pasted or used as space-filler and doesn't offer much of value.

Remove it to simplify/standardize these pages and make changes to how this field works simpler to implement.

Test Plan

Viewed a Credential, Blog, and Space; no longer saw the "Editable By" field.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 12 2019, 4:37 PM
This revision was automatically updated to reflect the committed changes.