Page MenuHomePhabricator
Differential D20679

Tailor "Restart All Builds" for the complex realities of modern build restart rules
ClosedPublic
Actions

Authored by epriestley on Jul 24 2019, 3:14 PM.
Tags
None
Referenced Files
F13262616: D20679.diff
Mon, May 27, 2:19 AM
F13245880: D20679.diff
Thu, May 23, 6:25 AM
F13238063: D20679.diff
Tue, May 21, 4:55 PM
F13237829: D20679.id.diff
Tue, May 21, 3:17 PM
F13225929: D20679.diff
Sun, May 19, 6:19 PM
F13215988: D20679.id49322.diff
Fri, May 17, 9:38 PM
F13214926: D20679.id49322.diff
Fri, May 17, 1:49 PM
F13197708: D20679.diff
Mon, May 13, 12:25 AM
View All Files
Subscribers
Restricted Owners Package
Tokens
"Y So Serious" token, awarded by jmeador.

Details

Reviewers
amckinley
Maniphest Tasks
T13348: "Restart All Builds" is misleading in the presence of non-restartable builds
Commits
rPf6621a5fdcff: Tailor "Restart All Builds" for the complex realities of modern build restart…
Summary

Fixes T13348. Currently, the Harbormaster UI shows "Restart All Builds", but it really means "Restart Restartable Builds", which is often fewer than "All" builds (because of autobuilds, permissions, and/or configuration).

Remove the misleading term "All" and make the workflow preview exactly which builds will and will not be affected, and why.

Test Plan

Screen Shot 2019-07-24 at 8.11.41 AM.png (785×1 px, 162 KB)

Screen Shot 2019-07-24 at 8.11.10 AM.png (762×1 px, 173 KB)

Screen Shot 2019-07-24 at 8.11.02 AM.png (762×1 px, 172 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
harbormaster/
controller/
155 lines
8 lines

Diff 49322

View Options

src/applications/harbormaster/controller/HarbormasterBuildableActionController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterBuildableViewController.php

Loading...
Phabricator · Built by Phacility