Page MenuHomePhabricator

Allow "PhutilClassMapQuery" to sort with a PhutilSortVector sort function
ClosedPublic

Authored by epriestley on Jun 22 2019, 4:03 PM.
Tags
None
Referenced Files
F13283122: D20611.diff
Sun, Jun 2, 12:51 PM
F13271237: D20611.diff
Wed, May 29, 6:39 PM
F13258552: D20611.id49158.diff
Sun, May 26, 10:27 AM
F13252126: D20611.diff
Sat, May 25, 1:06 AM
F13204448: D20611.diff
Wed, May 15, 12:35 AM
F13198996: D20611.diff
Mon, May 13, 10:53 AM
F13187407: D20611.diff
Sat, May 11, 4:30 AM
Unknown Object (File)
Tue, May 7, 7:37 AM
Subscribers
None

Details

Summary

Ref T13303. I didn't find any explicit "msortv()" issues in instances/, but did catch one during deploy where we run a ClassMapQuery with a vector-returning sort method.

Test if the sort method returns vectors and "msortv()" it if it does.

Test Plan

Will cherry-pick and redeploy, just throwing this up for reference/context.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable