Paths

Table of Contentst

Differential D20555

Add a hook method that is called before `ArcanistLinter::getLinterConfigurationOptions`
Needs ReviewPublic
Actions

Authored by joshuaspence on May 24 2019, 4:45 AM.

Tags

None

Referenced Files

	F13187671: D20555.diff
	Sat, May 11, 4:41 AM

	F13183508: D20555.diff
	Fri, May 10, 9:46 AM

	Unknown Object (File)
	Tue, May 7, 7:52 AM

	Unknown Object (File)
	Fri, May 3, 7:31 AM

	Unknown Object (File)
	Mon, Apr 29, 12:11 PM

	Unknown Object (File)
	Thu, Apr 25, 1:35 AM

	Unknown Object (File)
	Mon, Apr 22, 9:23 AM

	Unknown Object (File)
	Fri, Apr 19, 3:07 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Summary

I am writing a third-party linter which allows different configuration options depending on the value of one specific configuration option. This diff adds a ArcanistLinter::willSetLinterConfiguration hook method that is called before ArcanistLinter::getLinterConfigurationOptions to facilitate this type of functionality.

Test Plan

N/A

Diff Detail

Repository

Branch

lint6

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22911
Build 31431: Run Core Tests
Build 31430: arc lint + arc unit

Event Timeline

joshuaspence created this revision.May 24 2019, 4:45 AM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 24 2019, 4:45 AM

Harbormaster completed remote builds in B22911: Diff 49038.May 24 2019, 4:45 AM

joshuaspence requested review of this revision.May 24 2019, 4:45 AM

Herald added a subscriber: Korvin. · View Herald TranscriptMay 24 2019, 4:45 AM

joshuaspence added inline comments.May 26 2019, 10:19 PM

src/lint/linter/ArcanistLinter.php
490	Alternative method names: `willSetLinterConfigurationOptions` `willSetLinterConfigurationValues`

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

src/

lint/

engine/

ArcanistConfigurationDrivenLintEngine.php

1 line

0%

Loading...

linter/

ArcanistLinter.php

4 lines

49%

Loading...

Diff 49038

src/lint/engine/ArcanistConfigurationDrivenLintEngine.php

Loading...

src/lint/linter/ArcanistLinter.php

Loading...