Page MenuHomePhabricator

Be more strict when checking linter versions
Needs ReviewPublic

Authored by joshuaspence on May 22 2019, 1:25 AM.
Tags
None
Referenced Files
F13196521: D20542.diff
Sun, May 12, 11:20 PM
F13183526: D20542.diff
Fri, May 10, 10:05 AM
Unknown Object (File)
Mon, May 6, 12:54 PM
Unknown Object (File)
Sat, May 4, 6:22 AM
Unknown Object (File)
Fri, May 3, 5:02 AM
Unknown Object (File)
Tue, Apr 30, 10:21 PM
Unknown Object (File)
Sun, Apr 28, 11:10 PM
Unknown Object (File)
Sun, Apr 28, 11:17 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Curently ArcanistExternalLinterTestCase::testVersion passes so long as the linter being tested returns anything other than the literal false. Make this more strict by asserting that the return value must have a non-zero length.

Test Plan

Ran unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
lint4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22864
Build 31369: Run Core Tests
Build 31368: arc lint + arc unit