Paths

Table of Contentst

Differential D20541

Use the checkstyle reporter with JSHint
Needs ReviewPublic
Actions

Authored by joshuaspence on May 22 2019, 12:59 AM.

Tags

None

Referenced Files

	F13177145: D20541.diff
	Wed, May 8, 7:29 PM

	Unknown Object (File)
	Sun, May 5, 4:24 AM

	Unknown Object (File)
	Sun, May 5, 4:15 AM

	Unknown Object (File)
	Thu, May 2, 8:41 AM

	Unknown Object (File)
	Wed, May 1, 8:24 AM

	Unknown Object (File)
	Mon, Apr 22, 9:23 AM

	Unknown Object (File)
	Fri, Apr 19, 3:14 AM

	Unknown Object (File)
	Fri, Apr 19, 3:14 AM

View All 84 Files

Subscribers

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Summary

Use the built-in checkstyle reporter instead of our custom reporter.js file for ArcanistJSHintLinter. --reporter=checkstyle has been available since at least 2012.

Test Plan

Ran unit tests.

Diff Detail

Repository

rARC Arcanist

Branch

lint3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22862
Build 31365: Run Core Tests
Build 31364: arc lint + arc unit

Event Timeline

joshuaspence created this revision.May 22 2019, 12:59 AM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 22 2019, 12:59 AM

Harbormaster completed remote builds in B22862: Diff 48986.May 22 2019, 1:00 AM

joshuaspence requested review of this revision.May 22 2019, 1:00 AM

Herald added a subscriber: Korvin. · View Herald TranscriptMay 22 2019, 1:00 AM

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

src/

lint/

linter/

ArcanistJSHintLinter.php

36 lines

52%

reporter.js

Diff 48986

View Options

src/lint/linter/ArcanistJSHintLinter.php