Page MenuHomePhabricator

Remove very old "vsDiff" data from commit update / diff extraction pipeline
ClosedPublic

Authored by epriestley on Apr 11 2019, 1:12 PM.
Tags
None
Referenced Files
F13288058: D20395.diff
Tue, Jun 4, 9:44 AM
F13275943: D20395.diff
Fri, May 31, 5:22 AM
F13228535: D20395.id48675.diff
Mon, May 20, 10:15 AM
F13221462: D20395.diff
Sun, May 19, 2:47 AM
F13203854: D20395.diff
Wed, May 15, 12:09 AM
F13190283: D20395.diff
Sat, May 11, 9:13 AM
F13186442: D20395.diff
Sat, May 11, 3:38 AM
Unknown Object (File)
Tue, May 7, 6:54 AM
Subscribers
None

Details

Summary

Ref T13276. This was introduced in D2586 to power a "trigger audits when the committed change does not match the reviewed change" feature. It was removed without ceremony in D15939. Broadly, rebases mean that this sort of feature can't really work like this and this approach is inherently unreliable; see also T182.

This property no longer has readers, and is unlikely to get any in the future since my planned pathway for "committed code must match reviewed code, modulo an automated rebase" is automating the rebase via "Land Revision", not comparing the diff text.

Remove this to simplify the flow of data here so that things in T13276 can be fixed more easily.

Test Plan

Grepped for vsDiff, no hits.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable