Page MenuHomePhabricator

Fix task hovercards showing a "Not Editable" state
ClosedPublic

Authored by epriestley on Mar 26 2019, 10:47 PM.
Tags
None
Referenced Files
F13205321: D20330.diff
Wed, May 15, 1:49 AM
F13188741: D20330.diff
Sat, May 11, 5:27 AM
Unknown Object (File)
Tue, May 7, 9:10 AM
Unknown Object (File)
Fri, May 3, 8:51 AM
Unknown Object (File)
Thu, May 2, 6:08 PM
Unknown Object (File)
Thu, Apr 25, 2:39 AM
Unknown Object (File)
Wed, Apr 24, 8:50 PM
Unknown Object (File)
Sun, Apr 21, 7:38 PM
Subscribers
None

Details

Summary

Ref T13269. These cards really have three states:

  • Editable: shows a pencil icon edit button.
  • You Do Not Have Permission To Edit This: shows a "no editing" icon in red.
  • Hovecard: shouldn't show anything.

However, the "hovercard" and "no permission" states are currently the same state, so when I made the "no permission" state more obvious that made the hovercard go all weird.

Make these states explicitly separate states.

Test Plan

Looked at a...

  • Editable card on workboard: edit state.
  • No permission card on workboard: no permission state.
  • Any hovercard: "not editable, this is a hovercard" state.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable