Page MenuHomePhabricator

When users hover over a column trigger menu, show a "preview" with the rules instead of a tooltip
ClosedPublic

Authored by epriestley on Mar 21 2019, 8:23 PM.
Tags
None
Referenced Files
F13295445: D20304.diff
Thu, Jun 6, 3:03 AM
F13295287: D20304.diff
Thu, Jun 6, 12:30 AM
F13280913: D20304.diff
Sun, Jun 2, 9:28 AM
F13210482: D20304.diff
Fri, May 17, 4:54 AM
F13194455: D20304.diff
Sun, May 12, 9:35 PM
F13179037: D20304.diff
Wed, May 8, 8:53 PM
Unknown Object (File)
May 6 2024, 12:58 PM
Unknown Object (File)
May 6 2024, 4:44 AM
Subscribers
None

Details

Summary

Ref T5474. The first rough cut of triggers showed some of the trigger rules in a tooltip when you hover over the "add/remove" trigger menu.

This isn't great since we don't have much room and it's a bit finnicky / hard to read.

Since we have a better way to show effects now in the drop preview, just use that instead. When you hover over the trigger menu, preview the trigger in the "drop effect" element, with a "Trigger: such-and-such" header.

Test Plan
  • This is pretty tough to screenshot.
  • Hovered over menu, got a sensible preview of the trigger effects.
  • Dragged a card over the menu, no preview.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable