Differential D20030

Update Google OAuth adapter to move away from deprecated "Google+" APIs
ClosedPublic
Actions

Authored by epriestley on Jan 25 2019, 1:48 AM.

Tags

None

Referenced Files

	F13267536: D20030.diff
	Wed, May 29, 3:37 AM

	F13252984: D20030.diff
	Sat, May 25, 2:16 AM

	F13230774: D20030.diff
	Mon, May 20, 11:19 PM

	F13222899: D20030.id47863.diff
	Sun, May 19, 4:05 AM

	F13214691: D20030.id.diff
	Fri, May 17, 12:25 PM

	F13213964: D20030.diff
	Fri, May 17, 8:19 AM

	F13209913: D20030.diff
	Fri, May 17, 2:50 AM

	F13196082: D20030.diff
	Sun, May 12, 10:55 PM

View All 100 Files

Subscribers

Details

Reviewers

amckinley
dragoon20

Maniphest Tasks

T13227: Figure out if Google Auth needs to be updated before Google+ shutdown on March 7, 2019

Commits

rPHU9144fc5a6896: (stable) Promote 2019 Week 4
rPHU9456d6683d33: Update Google OAuth adapter to move away from deprecated "Google+" APIs

Summary

Fixes T13227.

Test Plan

Screen Shot 2019-01-24 at 5.47.10 PM.png (807×1 px, 168 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 25 2019, 1:48 AM

Harbormaster completed remote builds in B21690: Diff 47836.Jan 25 2019, 1:49 AM

epriestley requested review of this revision.Jan 25 2019, 1:49 AM

epriestley added inline comments.Jan 25 2019, 1:50 AM

src/auth/PhutilGoogleAuthAdapter.php
150	None of these instructions seem to make sense anymore and I suspect this "Enable Google+" error is now impossible. Fingers crossed until evidence surfaces to suggest otherwise.

epriestley mentioned this in D20015: Adjust Google Auth Adapter to use Open ID Connect.Jan 25 2019, 1:51 AM

I tested this and it works marvelous, thanks, waiting for the patch.

Macro lgtmacro:

This revision is now accepted and ready to land.Jan 25 2019, 3:04 AM

Closed by commit rPHU9456d6683d33: Update Google OAuth adapter to move away from deprecated "Google+" APIs (authored by epriestley). · Explain WhyJan 28 2019, 5:40 PM

This revision was automatically updated to reflect the committed changes.

reed added a subscriber: reed.Feb 22 2019, 4:40 PM

Revision Contents
Changeset List

Path

Size

src/

auth/

PhutilGoogleAuthAdapter.php

92 lines

Diff 47863

src/auth/PhutilGoogleAuthAdapter.php

Loading...