Page MenuHomePhabricator

Support %P (Password or Secret) in qsprintf()
ClosedPublic

Authored by epriestley on Nov 7 2018, 12:34 AM.
Tags
None
Referenced Files
F13269862: D19782.diff
Wed, May 29, 7:59 AM
F13262328: D19782.diff
Mon, May 27, 2:01 AM
F13217135: D19782.id47248.diff
Sat, May 18, 3:42 AM
F13212351: D19782.diff
Fri, May 17, 6:37 AM
F13195897: D19782.diff
Sun, May 12, 10:43 PM
F13179776: D19782.diff
Wed, May 8, 9:26 PM
Unknown Object (File)
Sat, May 4, 7:04 PM
Unknown Object (File)
Thu, May 2, 9:25 AM
Subscribers
None

Details

Summary

Depends on D19781. Fixes T6960. Ref T13217. Ref T13216. Occasionally, we issue queries which contain passwords or secrets. Supporting "%P" (similar to the csprintf() "%P") allows us to mask these in logs and output while still generating the correct values when we actually execute a query.

Test Plan
$ cat test.php 
<?php

require_once 'scripts/init/init-script.php';

$conn = id(new PhabricatorUser())->establishConnection('r');

$query = qsprintf(
  $conn,
  'SELECT %P',
  new PhutilOpaqueEnvelope('hunter2'));

echo $query."\n";
var_dump(queryfx_one($conn, '%Q', $query));
$ php -f test.php 
SELECT ********
array(1) {
  ["hunter2"]=>
  string(7) "hunter2"
}

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable