Differential D19465

[ARCUNIT] Set the ConfigurationManager of ConfigurationDrivenUnitTestEngines
ClosedPublic
Actions

Authored by tmcjilton on Jun 5 2018, 8:30 PM.

Tags

None

Referenced Files

	F13269824: D19465.diff
	Wed, May 29, 7:47 AM

	F13239250: D19465.id46560.diff
	Wed, May 22, 1:26 AM

	F13234352: D19465.diff
	Tue, May 21, 3:19 AM

	F13212652: D19465.id46560.diff
	Fri, May 17, 6:57 AM

	F13212035: D19465.diff
	Fri, May 17, 6:20 AM

	F13208801: D19465.id.diff
	Thu, May 16, 7:35 PM

	F13197054: D19465.diff
	Sun, May 12, 11:47 PM

	F13184700: D19465.id46561.diff
	Fri, May 10, 10:19 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARCb199ca808660: [ARCUNIT] Set the ConfigurationManager of ConfigurationDrivenUnitTestEngines

Required Signatures

L28 Phacility Individual Contributor License Agreement

Summary

The Configuration Manager is supported by ArcanistUnitTestEngine but not support by the ArcanistConfigurationDrivenUnitTestEngine.

Added the configuration manager as one of the initially set properties of an ArcUnitTestEngine created by the ArcanistConfigurationDrivenTestEngine

Test Plan

Ran arc unit against a project without the change, verified the Configuration was none. Added this change and ran again and verified it was set

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tmcjilton created this revision.Jun 5 2018, 8:30 PM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 5 2018, 8:30 PM

Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript

tmcjilton requested review of this revision.Jun 5 2018, 8:30 PM

Herald added a subscriber: Korvin. · View Herald TranscriptJun 5 2018, 8:30 PM

Harbormaster completed remote builds in B20368: Diff 46560.Jun 5 2018, 8:30 PM

Thanks! I added a CLA exemption for you and added you to Community (granting you sweeping janitorial powers) and Blessed Committers (so you should be able to land this yourself). See that project's detail page for instructions, and yell if you run into issues.

This revision is now accepted and ready to land.Jun 5 2018, 8:46 PM

(For future archaeology, see also PHI694.)

Closed by commit rARCb199ca808660: [ARCUNIT] Set the ConfigurationManager of ConfigurationDrivenUnitTestEngines (authored by tmcjilton). · Explain WhyJun 5 2018, 8:58 PM

This revision was automatically updated to reflect the committed changes.

image.png (448×484 px, 356 KB)

Revision Contents
Changeset List

Path

Size

src/

unit/

engine/

ArcanistConfigurationDrivenUnitTestEngine.php

1 line

Diff 46561

src/unit/engine/ArcanistConfigurationDrivenUnitTestEngine.php

Loading...