Page MenuHomePhabricator

Specify a null behavior for the callsign sort column.
ClosedPublic

Authored by 20after4 on Nov 14 2017, 11:13 PM.
Tags
None
Referenced Files
F13284510: D18773.id.diff
Mon, Jun 3, 5:52 AM
F13281208: D18773.diff
Sun, Jun 2, 9:51 AM
F13280402: D18773.id45047.diff
Sun, Jun 2, 4:37 AM
F13268353: D18773.diff
Wed, May 29, 4:56 AM
F13253869: D18773.diff
Sat, May 25, 3:00 AM
F13241526: D18773.diff
Wed, May 22, 10:00 PM
F13236375: D18773.diff
Tue, May 21, 9:26 AM
F13232848: D18773.diff
Tue, May 21, 1:31 AM
Subscribers

Details

Summary

Fixes paging on the Diffusion Repository List.

PhabricatorRepositoryQuery needs to specify a behavior for null on the OderableColumns definition for the callsign column.

See https://phabricator.wikimedia.org/T180457

Test Plan
  1. On an instance with more than 100 repositories
    • some of which are missing a callsign
  2. Attempt to sort by callsign.
  3. See the sorted results

Previously:

  1. Exception: "Column "0" has null value, but does not specify a null behavior."

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable