Page MenuHomePhabricator

Clean up virtual "_ft_rank" column for query construction of Ferret objects
ClosedPublic

Authored by epriestley on Oct 23 2017, 10:09 PM.
Tags
None
Referenced Files
F13255808: D18728.diff
Sat, May 25, 8:18 AM
F13228186: D18728.id44957.diff
Mon, May 20, 7:48 AM
F13219964: D18728.diff
Sat, May 18, 10:21 PM
F13210303: D18728.id44957.diff
Fri, May 17, 4:42 AM
F13199599: D18728.diff
Mon, May 13, 4:11 PM
F13191940: D18728.diff
Sun, May 12, 2:55 AM
F13181940: D18728.diff
Thu, May 9, 5:11 PM
Unknown Object (File)
May 5 2024, 8:43 PM
Subscribers
None

Details

Summary

Ref T12974. Ferret object queries SELECT a virtual "_ft_rank" column for relevance ordering.

Currently, they always SELECT this column. That's fine and doesn't hurt anything, but makes developing and debugging things kind of a pain since every query has this , blah blah _ft_rank junk.

Instead, construct this column only if we're actually going to use it.

Mostly, this cleans up DarkConsole / query logs a bit.

Test Plan

Viewed normal query results on various pages, viewed global search results, ordered Maniphest tasks by normal stuff and by "Relevance".

Viewed DarkConsole, saw no more "_ft_rank" junk on normal pages.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster completed remote builds in B18735: Diff 44955.
This revision is now accepted and ready to land.Oct 23 2017, 11:00 PM
This revision was automatically updated to reflect the committed changes.