Page MenuHomePhabricator

Clean up virtual "_ft_rank" column for query construction of Ferret objects
ClosedPublic

Authored by epriestley on Oct 23 2017, 10:09 PM.
Tags
None
Referenced Files
F19154285: D18728.id44957.diff
Thu, Dec 11, 2:09 PM
F19088899: D18728.id.diff
Wed, Dec 3, 5:31 AM
F19081079: D18728.diff
Tue, Dec 2, 3:51 AM
F18872481: D18728.id44955.diff
Nov 5 2025, 4:37 AM
F18855323: D18728.id.diff
Nov 1 2025, 4:53 AM
F18855189: D18728.diff
Nov 1 2025, 4:01 AM
F18841003: D18728.diff
Oct 28 2025, 5:45 AM
F18840652: D18728.diff
Oct 28 2025, 3:03 AM
Subscribers
None

Details

Summary

Ref T12974. Ferret object queries SELECT a virtual "_ft_rank" column for relevance ordering.

Currently, they always SELECT this column. That's fine and doesn't hurt anything, but makes developing and debugging things kind of a pain since every query has this , blah blah _ft_rank junk.

Instead, construct this column only if we're actually going to use it.

Mostly, this cleans up DarkConsole / query logs a bit.

Test Plan

Viewed normal query results on various pages, viewed global search results, ordered Maniphest tasks by normal stuff and by "Relevance".

Viewed DarkConsole, saw no more "_ft_rank" junk on normal pages.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster completed remote builds in B18735: Diff 44955.
This revision is now accepted and ready to land.Oct 23 2017, 11:00 PM
This revision was automatically updated to reflect the committed changes.