Page MenuHomePhabricator

Add a "/source/..." URI for Diffusion commits which redirects
ClosedPublic

Authored by epriestley on Oct 3 2017, 7:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 2, 5:06 AM
Unknown Object (File)
May 6 2025, 5:36 AM
Unknown Object (File)
May 6 2025, 12:29 AM
Unknown Object (File)
May 5 2025, 9:55 AM
Unknown Object (File)
Apr 12 2025, 11:22 AM
Unknown Object (File)
Apr 7 2025, 11:05 PM
Unknown Object (File)
Apr 5 2025, 3:25 PM
Unknown Object (File)
Apr 3 2025, 9:22 AM
Subscribers
None

Details

Summary

See PHI112. The install presumably wants to generate links to Diffusion commits from an external tool, but only knows the short name of the repository.

Provide a /source/phabricator/commit/abcdef908273 URI which redirects to the canonical URI for the commit.

Test Plan
  • Visited /source/ URI for a commit, got a redirect.
  • Visited normal URI for a commit, got a commit page.
  • Visited /branches/ and /tags/ for a /source/ repository, got proper pages.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Just out of curiosity, what happens if a commit identifier collides with more than one commit hash?

This revision is now accepted and ready to land.Oct 3 2017, 8:05 PM

Hmm.. bad stuff, but pre-existing bad stuff:

$ git log --oneline --format=%H | cut -c1-6 | sort | uniq -c | sort -n
...
   2 bd3c23

Yields this:

https://secure.phabricator.com/rPbd3c23

...which fatals, probably on executeOne().

Expected a single result!

Better behavior would be to execute(), then special case for multiple results.

This revision was automatically updated to reflect the committed changes.