Page MenuHomePhabricator

Add a "Draft" state for revisions, and action bucket support
ClosedPublic

Authored by epriestley on Sep 18 2017, 7:57 PM.
Tags
None
Referenced Files
F13278061: D18625.id44719.diff
Fri, May 31, 6:26 PM
F13259237: D18625.diff
Sun, May 26, 6:17 PM
F13246351: D18625.diff
Thu, May 23, 9:39 AM
F13240039: D18625.id44719.diff
Wed, May 22, 9:42 AM
F13221261: D18625.diff
Sun, May 19, 2:24 AM
F13203678: D18625.diff
Tue, May 14, 11:59 PM
F13186172: D18625.diff
Sat, May 11, 3:28 AM
Unknown Object (File)
Tue, May 7, 6:15 AM
Subscribers
None

Details

Summary

Ref T2543. There's no way to put revisions into this state yet, but start adding support for when there is.

Adds the status constant, plus support for bucketing them.

Test Plan
  • Manually put a revision in "Draft" state by updating the database directly.
  • Verified my drafts showed up in a "Drafts" section on the bucket view.
  • Verified others' drafts did not appear on the action bucket view.
  • Viewed revisions, queried for "Draft" revisions, etc (stuff we get for free).

Screen Shot 2017-09-18 at 12.56.40 PM.png (132×274 px, 14 KB)

Screen Shot 2017-09-18 at 12.54.05 PM.png (235×284 px, 21 KB)

Screen Shot 2017-09-18 at 12.54.00 PM.png (236×396 px, 20 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable