Page MenuHomePhabricator

Don't prompt to mark notifications as read if we don't need to
ClosedPublic

Authored by epriestley on Aug 28 2017, 7:18 PM.
Tags
None
Referenced Files
F13269634: D18483.diff
Wed, May 29, 6:33 AM
F13259473: D18483.diff
Sun, May 26, 8:59 PM
F13255394: D18483.diff
Sat, May 25, 4:46 AM
F13249944: D18483.id44401.diff
Fri, May 24, 12:08 PM
F13234907: D18483.diff
Tue, May 21, 3:54 AM
F13225134: D18483.id44402.diff
Sun, May 19, 1:38 PM
F13212835: D18483.diff
Fri, May 17, 7:07 AM
F13197724: D18483.diff
Mon, May 13, 12:26 AM
Subscribers
None

Details

Summary

Fixes whatever task is tracking this junk, if one exists. Don't prompt unless there's a security issue.

Test Plan
  • Generated notifications from a test account.
  • Clicked "Mark All" from dropdown menu, no prompt.
  • Clicked "Mark All" from notifications screen, no prompt.
  • Command-Clicked "Mark All" from dropdown menu to open in new window, got normal prompt.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable