Page MenuHomePhabricator

Replace Differential hard-coded status "<select />" with tokenizer
ClosedPublic

Authored by epriestley on Aug 11 2017, 3:13 PM.
Tags
None
Referenced Files
F13281904: D18393.diff
Sun, Jun 2, 11:25 AM
F13265396: D18393.diff
Tue, May 28, 4:15 AM
F13258652: D18393.id.diff
Sun, May 26, 11:33 AM
F13233394: D18393.id.diff
Tue, May 21, 2:16 AM
F13229703: D18393.id44207.diff
Mon, May 20, 6:33 PM
F13224325: D18393.id44234.diff
Sun, May 19, 7:46 AM
F13217986: D18393.id.diff
Sat, May 18, 9:15 AM
F13214692: D18393.diff
Fri, May 17, 12:26 PM
Subscribers
None
Tokens
"Cup of Joe" token, awarded by chad.

Details

Summary

Ref T2543. This updates the UI control in the web UI. Also:

  • This implicitly makes this queryable with the API (differential.revision.search); it previously was not.
  • This does NOT migrate existing saved queries. I'll do those in the next change, and hold this until it happens.
  • This will break some existing /differential/?status=XYZ links. For example, status=open now needs to be status=open(). I couldn't find any of these in the upstream, and I suspect these are rare in the wild (users would normally link directly to saved queries, not use URI query construction).
Test Plan

Screen Shot 2017-08-11 at 8.09.44 AM.png (155×412 px, 23 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable