Remove incorrect policy language on Diff reviewers
ClosedPublic
Actions

Authored by chad on Aug 6 2017, 2:34 AM.

Tags

None

Referenced Files

	F13229401: D18349.diff
	Mon, May 20, 4:15 PM

	F13227873: D18349.diff
	Mon, May 20, 5:22 AM

	F13219962: D18349.id44109.diff
	Sat, May 18, 10:19 PM

	F13182446: D18349.diff
	Thu, May 9, 11:29 PM

	Unknown Object (File)
	Mon, May 6, 2:52 PM

	Unknown Object (File)
	Mon, May 6, 2:08 AM

	Unknown Object (File)
	Sat, May 4, 4:17 AM

	Unknown Object (File)
	Thu, May 2, 8:46 PM

View All 96 Files

Subscribers

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T12952: Reviewer not able to see diff

Commits

rP8ca29a607a2b: Remove incorrect policy language on Diff reviewers

Summary

Fixes T12952. This never work AFAIK, so resolves this mis-information. See T4411 for follow up.

Test Plan

Click on policy for a diff, no longer see text.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.Aug 6 2017, 2:34 AM

Harbormaster completed remote builds in B17922: Diff 44103.Aug 6 2017, 2:34 AM

Herald added a subscriber: Korvin. · View Herald TranscriptAug 6 2017, 2:34 AM

Harbormaster completed remote builds in B17922: Diff 44103.Aug 6 2017, 2:35 AM

epriestley accepted this revision.Aug 6 2017, 11:44 AM

This revision is now accepted and ready to land.Aug 6 2017, 11:44 AM

Closed by commit rP8ca29a607a2b: Remove incorrect policy language on Diff reviewers (authored by chad, committed by chad). · Explain WhyAug 6 2017, 3:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

storage/

DifferentialRevision.php

1 line

Diff 44109

View Options

src/applications/differential/storage/DifferentialRevision.php

Remove incorrect policy language on Diff reviewersClosedPublicActions