Page MenuHomePhabricator
Differential D18306

Move Phabricator to use PhutilBinaryAnalyzer and show binary versions
ClosedPublic
Actions

Authored by epriestley on Jul 31 2017, 7:23 PM.
Tags
None
Referenced Files
F13267471: D18306.diff
Wed, May 29, 3:26 AM
F13252912: D18306.diff
Sat, May 25, 2:12 AM
F13231227: D18306.diff
Tue, May 21, 12:17 AM
F13225334: D18306.diff
Sun, May 19, 2:41 PM
F13216615: D18306.id44026.diff
Sat, May 18, 1:34 AM
F13210422: D18306.diff
Fri, May 17, 4:50 AM
F13209158: D18306.id.diff
Thu, May 16, 10:14 PM
F13196032: D18306.diff
Sun, May 12, 10:52 PM
View All Files
Subscribers
alexnb

Details

Reviewers
chad
Maniphest Tasks
T12942: Add a "Binary Versions" page to Config
Commits
rPf48f2dae9f39: Move Phabricator to use PhutilBinaryAnalyzer and show binary versions
Summary

Fixes T12942.

  • Adds binary version and path information to Config → Version Information.
  • Replaces old code all over the place with new consolidated code.
Test Plan

Screen Shot 2017-07-31 at 12.14.42 PM.png (341×777 px, 101 KB)

Also faked some cases of missing binaries, bad versions, etc.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Jul 31 2017, 7:23 PM
Harbormaster failed remote builds in B17852: Diff 44014!Jul 31 2017, 7:24 PM
epriestley added a comment.Jul 31 2017, 7:24 PM

(Build just fails because this depends on D18305.)

chad accepted this revision.Jul 31 2017, 7:31 PM
This revision is now accepted and ready to land.Jul 31 2017, 7:31 PM
Closed by commit rPf48f2dae9f39: Move Phabricator to use PhutilBinaryAnalyzer and show binary versions (authored by epriestley, committed by epriestley). · Explain WhyAug 1 2017, 2:14 PM
This revision was automatically updated to reflect the committed changes.
alexnb added a subscriber: alexnb.Aug 1 2017, 7:39 PM
This comment was removed by alexnb.
epriestley added a comment.Aug 1 2017, 7:41 PM

Neither this change nor D18305 are on stable. If you encountered an issue, you're probably mixing stable and master.

alexnb added a comment.Aug 1 2017, 7:53 PM

I am sorry, my phabricator was on master. Unfortunately I use git only for phabricator maintenance, resulting in such confusion.

Revision Contents
Changeset List

Diff 44026

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/config/check/PhabricatorBinariesSetupCheck.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigVersionController.php

Loading...
View Options

src/applications/diffusion/query/lowlevel/DiffusionLowLevelMercurialPathsQuery.php

Loading...
View Options

src/applications/diffusion/query/lowlevel/__tests__/DiffusionLowLevelMercurialPathsQueryTests.php

Loading...
View Options

src/applications/repository/constants/PhabricatorRepositoryVersion.php

Loading...
View Options

src/applications/repository/engine/PhabricatorRepositoryPullEngine.php

Loading...
Phabricator · Built by Phacility