Page MenuHomePhabricator

Add a DiffusionTagListView
ClosedPublic

Authored by chad on Jun 11 2017, 7:08 PM.
Tags
None
Referenced Files
F13281413: D18115.diff
Sun, Jun 2, 10:38 AM
F13244613: D18115.diff
Thu, May 23, 5:11 AM
F13227592: D18115.id43598.diff
Mon, May 20, 4:20 AM
F13225272: D18115.id.diff
Sun, May 19, 2:20 PM
F13194705: D18115.diff
Sun, May 12, 9:48 PM
F13180940: D18115.diff
Thu, May 9, 6:13 AM
F13177464: D18115.diff
Wed, May 8, 7:44 PM
Unknown Object (File)
May 1 2024, 10:57 AM
Subscribers

Details

Summary

Moves DiffusionTagsListView to uhhh, list. Separates out table view which is still in use now, implements mobile friendly UI for tags.

Test Plan

Review KDE's Krita repository locally with lots of tags, desktop and mobile.

Screen Shot 2017-06-11 at 12.07.29 PM.png (1×2 px, 540 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

It's a little odd to me that this has "History", but branches has "Compare". I would expect both branches and tags to support the same operations.

This revision is now accepted and ready to land.Jun 12 2017, 4:25 PM

To clarify, you want history and compare on both?

oh i see, I linked history to the timestamp on the browse interface. I can button-ify that.

I would personally say:

  • The target of the link (stable) should possibly be history, not browse. This isn't how things work now, and isn't what GitHub does, but at least part of the old behavior was for consistency with the file lists, where the target of the link should "obviously" be browse, not history. Previously, file lists and branch lists appeared right next to one another with similar UI, so making them inconsistent could have been confusing. Since they're now more separate, I think there's a stronger argument for making "history" the default.
  • I think offering "Compare" in both UIs is reasonable.
  • I'm not sure we need "browse" from this UI at all. In cases where I'm interacting with branches I'm never concerned about what the repository looks like at the branch head: I believe I always care about the commit history.
  • add browse, compare button, make history default

I think I've normalized all the views here ( History, Tags, Branches ) but if something sticks out as inconsistent or I mis-read any feedback, give a hollar.

This revision was automatically updated to reflect the committed changes.

I'm still importing an HG repo for testing, at 20%