Page MenuHomePhabricator

Set project's ObjectName to its PHID when it doesn't have a hashtag
ClosedPublic

Authored by jcox on May 1 2017, 1:19 PM.
Tags
None
Referenced Files
F13269703: D17807.diff
Wed, May 29, 6:53 AM
F13260645: D17807.diff
Mon, May 27, 12:11 AM
F13243084: D17807.diff
Thu, May 23, 3:19 AM
F13236470: D17807.id42820.diff
Tue, May 21, 9:50 AM
F13223090: D17807.diff
Sun, May 19, 4:16 AM
F13177067: D17807.diff
Wed, May 8, 7:07 PM
Unknown Object (File)
Apr 29 2024, 4:07 PM
Unknown Object (File)
Apr 28 2024, 7:09 PM
Subscribers

Details

Summary

Fixes T12659. Previously this would lead to an error when trying to run arc diff on a revision that had a milestone as a reviewer (or any non-octothorpe'd Object Name)

Test Plan

Followed repro steps in T12659 and didn't get the error described. Also clicked around and didn't notice any obvious regressions in projects or differential

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable