Page MenuHomePhabricator
Differential D17793

Add an Owners Package hovercard
ClosedPublic
Actions

Authored by chad on Apr 26 2017, 12:31 AM.
Tags
None
Referenced Files
F13269702: D17793.diff
Wed, May 29, 6:53 AM
F13269573: D17793.diff
Wed, May 29, 6:28 AM
F13255021: D17793.diff
Sat, May 25, 4:20 AM
F13234797: D17793.diff
Tue, May 21, 3:45 AM
F13212760: D17793.diff
Fri, May 17, 7:02 AM
F13201466: D17793.id.diff
Tue, May 14, 12:29 PM
F13197490: D17793.diff
Mon, May 13, 12:13 AM
F13184022: D17793.id.diff
Fri, May 10, 2:20 PM
View All Files
Subscribers
jmeador
Korvin

Details

Reviewers
epriestley
jmeador
Maniphest Tasks
T12600: Update Hovercards
Commits
rP782471052265: Add an Owners Package hovercard
Summary

Ref T12600. Basically all the property (not path) information on a hovercard for owner packages.

Test Plan

Create a package with LOTS OF RULES. Test it as open and archived states.

pasted_file (494×976 px, 62 KB)

pasted_file (496×1 px, 69 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad created this revision.Apr 26 2017, 12:31 AM
Herald added a subscriber: Korvin. · View Herald TranscriptApr 26 2017, 12:31 AM
chad edited the test plan for this revision. (Show Details)Apr 26 2017, 12:32 AM
Harbormaster completed remote builds in B16712: Diff 42785.Apr 26 2017, 12:32 AM
chad edited the test plan for this revision. (Show Details)Apr 26 2017, 12:34 AM
jmeador accepted this revision.Apr 26 2017, 6:58 AM
jmeador added a subscriber: jmeador.

Really a very very beautiful hovercard. It's going to be great. Fantastic job. Really really proud of this hovercard.

This revision is now accepted and ready to land.Apr 26 2017, 6:58 AM
Closed by commit rP782471052265: Add an Owners Package hovercard (authored by chad, committed by chad). · Explain WhyApr 26 2017, 3:45 PM
This revision was automatically updated to reflect the committed changes.
epriestley edited edge metadata.Apr 26 2017, 5:04 PM

Couple inlines just to prove that I looked.

We could probably drop "Auto Review" and "Dominion", I think they're probably only of much use when editing/configuring the package.

src/applications/owners/engineextension/PhabricatorOwnersHovercardEngineExtension.php
49

Could use getMonogram().

src/view/phui/PHUIHovercardView.php
123

What about common and useful title "0"?!

chad added inline comments.Apr 26 2017, 5:06 PM
src/view/phui/PHUIHovercardView.php
123

dammit

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
owners/
engineextension/
89 lines
view/
phui/
7 lines

Diff 42787

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/owners/engineextension/PhabricatorOwnersHovercardEngineExtension.php

Loading...
View Options

src/view/phui/PHUIHovercardView.php

Loading...
Phabricator · Built by Phacility