Page MenuHomePhabricator

Improve `ArcanistLinterStandardTestCase`
Needs ReviewPublic

Authored by wjiang on Apr 24 2017, 1:04 AM.
Tags
None
Referenced Files
F13226890: D17783.diff
Sun, May 19, 11:55 PM
F13211376: D17783.diff
Fri, May 17, 5:42 AM
F13196620: D17783.diff
Sun, May 12, 11:25 PM
F13176542: D17783.diff
Wed, May 8, 2:52 PM
Unknown Object (File)
Sun, May 5, 2:16 AM
Unknown Object (File)
Fri, May 3, 5:42 AM
Unknown Object (File)
Wed, May 1, 8:05 AM
Unknown Object (File)
Mon, Apr 29, 3:37 PM

Details

Summary

Ref T12631. Let unit test actually test ArcanistLinterStandard.

Test Plan

Run unit test

Diff Detail

Repository
rARC Arcanist
Branch
arcpatch-D17783
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16794
Build 22413: arc lint + arc unit

Event Timeline

joshuaspence added a subscriber: joshuaspence.

LGTM. @epriestley, it would be greatly appreciated if this could be accepted upstream. We have a large number of XHPAST linter rules (I think ~200) and we want to write integration tests to ensure that they play nicely together.

src/lint/linter/standards/__tests__/ArcanistLinterStandardTestCase.php
4

You should extend ArcanistLinterTestCase instead

5–8

You might want to leave this.

8

Maybe call this getBaseLinter?

10

I think this should be called getStandard

15–18

Ideally, we should have some sort of $linter->applyStandard($standard) method... because this code is currently duplicated from ArcanistLinter

wjiang marked 5 inline comments as done.
  • Add applyStandard