Page MenuHomePhabricator

Make Applications extend LiskDAO
ClosedPublic

Authored by epriestley on Apr 19 2017, 10:58 PM.
Tags
None
Referenced Files
F13273133: D17738.diff
Fri, May 31, 1:36 AM
F13241503: D17738.id42667.diff
Wed, May 22, 9:49 PM
F13203234: D17738.diff
Tue, May 14, 11:35 PM
F13185525: D17738.diff
Sat, May 11, 2:58 AM
F13182253: D17738.diff
Thu, May 9, 9:56 PM
F13181193: D17738.id42668.diff
Thu, May 9, 9:39 AM
Unknown Object (File)
Tue, May 7, 5:27 AM
Unknown Object (File)
May 3 2024, 2:52 AM
Subscribers
None

Details

Summary

Ref T11476. This is a bit hacky, but makes Application extend LiskDAO so we can apply transactions to it with an Editor class.

Also fixes schema stuff so builds should produce a clean bill of health again.

This might only get you slightly further, yell if you run into more trouble.

Test Plan
  • Ran bin/storage upgrade -f and got no warnings.
  • Browsed around, nothing exploded?

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I also got rid of TransactionComment since we don't have a table for it, it's optional, and we probably don't need to let users comment on applications (hopefully?).

amckinley added inline comments.
src/applications/base/PhabricatorApplication.php
36

Sung to the tune of "Doctor Zaius Doctor Zaius"

This revision is now accepted and ready to land.Apr 19 2017, 11:02 PM
This revision was automatically updated to reflect the committed changes.