Fix an issue with FileFinder finding "." as a directory
ClosedPublic
Actions

Authored by epriestley on Mar 3 2017, 9:17 PM.

Tags

None

Referenced Files

	F13274459: D17455.diff
	Fri, May 31, 3:43 AM

	F13260499: D17455.diff
	Mon, May 27, 12:00 AM

	F13249089: D17455.id.diff
	Fri, May 24, 6:36 AM

	F13244688: D17455.diff
	Thu, May 23, 5:15 AM

	F13198811: D17455.diff
	Mon, May 13, 10:04 AM

	F13179294: D17455.diff
	Wed, May 8, 9:05 PM

	Unknown Object (File)
	Sat, May 4, 6:31 PM

	Unknown Object (File)
	Apr 24 2024, 11:41 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Commits

rPHUc26f7b429f71: Fix an issue with FileFinder finding "." as a directory

Summary

See D17430. This is buggy and hasn't come up before because we don't usually use the "d" (directory) mode.

Test Plan

Added a unit test and made it pass.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 3 2017, 9:17 PM

Harbormaster completed remote builds in B15881: Diff 41977.Mar 3 2017, 9:17 PM

Harbormaster completed remote builds in B15881: Diff 41977.

chad accepted this revision.Mar 3 2017, 9:24 PM

This revision is now accepted and ready to land.Mar 3 2017, 9:24 PM

Closed by commit rPHUc26f7b429f71: Fix an issue with FileFinder finding "." as a directory (authored by epriestley, committed by epriestley). · Explain WhyMar 3 2017, 9:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

filesystem/

FileFinder.php

13 lines

__tests__/

FileFinderTestCase.php

22 lines

Diff 41979

View Options

src/filesystem/FileFinder.php

View Options

src/filesystem/tests/FileFinderTestCase.php

Fix an issue with FileFinder finding "." as a directoryClosedPublicActions